chore: fix include pattern for test files in tsconfig.json
#269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lumirlumir
commented
Sep 22, 2025
| "mocha": "^11.0.0", | ||
| "prettier": "^3.6.0", | ||
| "rollup": "^4.16.2", | ||
| "rollup": "4.51.0", |
Member
Author
There was a problem hiding this comment.
Currently, Bun CI on Windows is failing due to the newly released Rollup 4.52.0.
As a workaround, I've pinned Rollup to 4.51.0.
Here are the references:
- Release: https://github.com/rollup/rollup/releases/tag/v4.52.0
- Issue: Latest update broke Bun rollup/rollup#6119
- PR: feat: Implement process.report.getReport() on Windows oven-sh/bun#22816
https://github.com/eslint/json/actions/runs/17880724585/job/50848015767
aladdin-add
approved these changes
Sep 22, 2025
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've corrected
includepattern for test files intsconfig.json.The current glob pattern with
{}isn't supported bytsconfig.json.As a result, intentionally failing a type test and running
npm run test:typesdoesn't report type errors becausetsconfig.jsondoesn't recognize that syntax as a glob pattern.Ref: https://www.typescriptlang.org/tsconfig/#include
What changes did you make? (Give an overview)
In this PR, I've corrected
includepattern for test files intsconfig.json.Related Issues
Ref: eslint/json#154
Is there anything you'd like reviewers to focus on?
N/A