Skip to content

Conversation

@lumirlumir
Copy link
Member

Hello,

This PR is a follow-up to eslint/eslint#19702.

I've updated the GitHub Actions CI workflow to include Node.js 24 in the test matrix and to remove the odd-numbered version, 21 and 23.

@lumirlumir
Copy link
Member Author

lumirlumir commented May 7, 2025

Oops, the tests using vitest are failing.

Could this be caused by an external dependency update?

image


I've updated the snapshots to the latest, and I believe everything should work as expected now!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 9314b1f into eslint:main May 7, 2025
12 of 19 checks passed
@lumirlumir lumirlumir deleted the ci-run-tests-in-nodejs-24 branch May 7, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants