-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add code path explorer #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
A few things to note:
|
|
What is the status of this PR? I'm asking because there is no description. |
|
Thank you for letting me know. I forgot to write a description at the top of this PR 😅. Now I wrote it. |
|
Thanks for the update @ota-meshi. I think we can definitely start to review this, and maybe someone will know how to fix the remaining tasks. The repo is still private, so only team members will be able to see it anyway. |
That's definitely okay for the first draft. We can look at doing this later.
It looks like there's an extension for that:
We don't have a preferred build system. If you did it using Vite, then let's stick with that.
No. We'll keep this as a separate site at |
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started, and sorry I missed it.
Some overall comments:
- Can you please add our standard file headers to each js/jsx file? That would really help to understand how things are organized.
- Similarly, can you add some comments in the js/jsx files explaining what is happening? Especially for someone like me who hasn't used React, there's a lot going on that's difficult to follow.
- Can you add some documentation explaining how the app is structured overall?
| "node": ">=18" | ||
| }, | ||
| "scripts": { | ||
| "build:website": "vite build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a start script that runs vite?
|
I think I've addressed some of the issues. But some challenges remain.
The remaining issues will be addressed when I have time. |
|
Thanks @ota-meshi. Because we'd like to get this done soon, would you mind if we brought on someone else to finish this? |
Of course it's okay 👍 |
|
Just FYI: we do have someone working on this, they just haven't pushed changes yet. Hopefully soon. |



Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Other, please explain: This PR adds a code path explorer page.
What changes did you make? (Give an overview)
This PR adds a code path explorer page.
Also, since this PR is the first page implementation, it also includes source code such as the build system.
Is there anything you'd like reviewers to focus on?
There is currently the following remaining task.
I would also like to hear your opinion on the following:
eslint.orglike in the playground? In that case, we will need to change to share the stylesheet as well.