Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text matching of MemberExpression nodes now includes the property name #47

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

RebeccaStevens
Copy link
Collaborator

Fixes #46

BREAKING CHANGE: ignoreAccessorPattern now matching the property name as well as the object name. Likewise with ignorePattern.

…lude the property name

BREAKING CHANGE: ignoreAccessorPattern now matching the property name as well as the object name. Likewise with ignorePattern.
@RebeccaStevens RebeccaStevens added the Type: Enhancement Enhancement of the code, not introducing new features. label Jul 28, 2019
@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #47 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   93.46%   93.61%   +0.14%     
==========================================
  Files          33       33              
  Lines         551      548       -3     
  Branches      106      105       -1     
==========================================
- Hits          515      513       -2     
  Misses         22       22              
+ Partials       14       13       -1
Impacted Files Coverage Δ
src/common/ignore-options.ts 95.45% <100%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e85cb5b...4968348. Read the comment docs.

@RebeccaStevens RebeccaStevens merged commit 3361e58 into master Jul 29, 2019
@RebeccaStevens RebeccaStevens deleted the ignore-options-match-properties branch July 29, 2019 00:50
RebeccaStevens pushed a commit that referenced this pull request Jan 4, 2021
Text matching of MemberExpression nodes now includes the property name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[immutable-data] Add option to ignore based on property name.
1 participant