Skip to content

chore: fix formatting generated files with ESLint #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023
Merged

chore: fix formatting generated files with ESLint #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/update-unicode-ids.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function restoreRanges(data: string): number[] {
fix: true,
baseConfig: { rules: { curly: "off" } },
})
const [result] = await engine.lintText(code, { filePath: "ids.ts" })
const [result] = await engine.lintText(code, { filePath: FILE_PATH })
Copy link
Member Author

@ota-meshi ota-meshi Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it is no longer formatted if we don't pass the correct file path. I think it's an effect of @typescript-eslint v2 changes.

code = result.output ?? code

logger.log("Writing '%s'...", FILE_PATH)
Expand Down
2 changes: 1 addition & 1 deletion scripts/update-unicode-properties.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export function isValidLoneUnicodeProperty(version: number, value: string): bool

logger.log("Formatting code...")
const engine = new ESLint({ fix: true })
const [result] = await engine.lintText(code, { filePath: "properties.ts" })
const [result] = await engine.lintText(code, { filePath: FILE_PATH })
code = result.output ?? code

logger.log("Writing '%s'...", FILE_PATH)
Expand Down