Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ES2025 duplicate named capturing groups #195

Merged
merged 10 commits into from
Jun 28, 2024
Merged

feat: add support for ES2025 duplicate named capturing groups #195

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3384bd4
feat: add support for ES2025 duplicate named capturing groups
ota-meshi Apr 13, 2024
3208456
add test cases and fix
ota-meshi Apr 14, 2024
803019a
add test cases
ota-meshi Apr 14, 2024
3711614
refactor
ota-meshi Apr 14, 2024
b74101b
fix
ota-meshi Apr 14, 2024
eb3552a
update ast types
ota-meshi Apr 14, 2024
bf0ea8e
add test case
ota-meshi Apr 15, 2024
44db75a
add test case
ota-meshi Apr 15, 2024
06d7dff
refactor
ota-meshi Apr 15, 2024
d7f0d66
refactor to be more consistent with acorn impl
ota-meshi Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test case
  • Loading branch information
@ota-meshi
ota-meshi committed Jun 14, 2024
commit 44db75abd304589ae3759b303fe5a43060eb968b
6 changes: 6 additions & 0 deletions test/fixtures/parser/literal/duplicate-named-capturing-group-invalid-2025.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@
"index": 25
}
},
"/(?<x>a)(?:(?<x>b)|(?<x>c))/": {
"error": {
"message": "Invalid regular expression: /(?<x>a)(?:(?<x>b)|(?<x>c))/: Duplicate capture group name",
"index": 16
}
},
"/(?:(?:(?<x>a)|(?<x>b)))(?<x>c)/": {
"error": {
"message": "Invalid regular expression: /(?:(?:(?<x>a)|(?<x>b)))(?<x>c)/: Duplicate capture group name",
Expand Down