fix: compatibility with Node 12 #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
changed the title
fisker
reviewed
Apr 16, 2025
.github/workflows/ci.yml
Outdated
| run: | | ||
| npm run test | ||
|
|
||
| # Load sec/index.js to check for syntax errors. |
fisker
approved these changes
Apr 16, 2025
|
🎉 This PR is included in version 4.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compatibility issue with Node.js v12 so that CI will fail if there is a compatibility issue with Node.js v12.
fixes #252
Memo:
I've modified and run CI several times and debugged with
echo $?and it seems that in case of syntax errors it returns exit code 0 in tests using mocha 🤔When I try it locally, it seems the exit code is 0 only when using Node12.
I made sure we caught the syntax error by calling
node src/index.mjs.