Skip to content

Conversation

@ota-meshi
Copy link
Member

close #104

This PR improves the detect-child-process rule with the following changes:

  • Changed to check module imports as well.
  • Changed to check import of node:child_process.
  • Changed to report immediate calls like require('child_process').exec(c).
  • Changed to report exec(c) calls with destructuring.
  • Changed to not report traceable require('child_process').

Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 64ae529 into main Jan 26, 2023
@nzakas nzakas deleted the improve-detect-child-process branch January 26, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve detect-child-process rule

3 participants