feat: Disable the no-unpublished-x rules in private packages
#57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
fix/disable-no-unpublished-rules-in-private-packages
branch
from
352d828 to
e21f938
Compare
|
can you update the failing tests to match the new behaviour? |
Author
|
Yup, will do ASAP! |
aladdin-add
reviewed
Oct 27, 2022
Private packages are never published so the `no-unpublished-import` and `no-unpublished-require` rules don't need to run. This also removes `"private": true` from most fixtures that would fail due to the rules no longer running. More information about private packages: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#private
Windvis
force-pushed
the
fix/disable-no-unpublished-rules-in-private-packages
branch
from
e21f938 to
7670a10
Compare
aladdin-add
changed the title
no-unpublished-x rules in private packagesno-unpublished-x rules in private packages
Windvis
deleted the
fix/disable-no-unpublished-rules-in-private-packages
branch
|
Feedback on this change: For those projects, you may want to set And I'd challenge that all use-cases that are "private packages" don't need to care about this rule being in effect. I'd even argue that the majority of cases should clearly separate |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private packages are never published so the
no-unpublished-importandno-unpublished-requirerules don't need to run.More information: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#private
This fixes the original issue from the eslint-plugin-node repo: mysticatea#77
It seems a lot of tests fail because their test fixture setups containI removedpackage.jsonfiles withprivate: trueset. I think that is just an issue with those textures andprivate: trueshould be removed there?"private": truewhere needed.