Skip to content

fix: range matching fails #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aladdin-add merged 2 commits into from
Jul 4, 2022
Merged

fix: range matching fails #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b4b169
fix: range matching fails
aladdin-add Jun 16, 2022
ca775f1
chore: add a test
aladdin-add Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/rules/no-unsupported-features/es-syntax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
const { rules: esRules } = require("eslint-plugin-es")
const { getInnermostScope } = require("eslint-utils")
const { Range } = require("semver")
const rangeSubset = require("semver/ranges/subset")
const getConfiguredNodeVersion = require("../../util/get-configured-node-version")
const getSemverRange = require("../../util/get-semver-range")
const mergeVisitorsInPlace = require("../../util/merge-visitors-in-place")
Expand Down Expand Up @@ -457,11 +458,11 @@ function defineVisitor(context, options) {
return true
}

if (aCase.supported instanceof Range) {
return !options.version.intersects(aCase.supported)
}

return options.version.intersects(getSemverRange(`<${aCase.supported}`))
const supported =
typeof aCase.supported === "string"
? getSemverRange(`>=${aCase.supported}`)
: aCase.supported
return !rangeSubset(options.version, supported)
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-unsupported-features/es-syntax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2493,7 +2493,7 @@ ruleTester.run(
})),
],
invalid: [
...["12.16.0", "13.0.0", "13.1.0"].map(v => ({
...["12.16.0", "13.0.0", "13.1.0", ">=8.0.0"].map(v => ({
code: "import(source)",
options: [{ version: v }],
errors: [
Expand Down