chore: Merge supported and backport properties #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scagood
commented
Jan 29, 2024
| name: "module.builtinModules", | ||
| supported: | ||
| "9.3.0 (backported: ^6.13.0, ^8.10.0)", | ||
| "9.3.0 (backported: ^8.10.0, ^6.13.0)", |
Author
There was a problem hiding this comment.
This will now always be sorted highest -> lowest for everything!
| // Core js builtins | ||
| AggregateError: { | ||
| [READ]: { supported: "15.0.0" }, | ||
| [READ]: { supported: ["15.0.0"] }, |
Author
There was a problem hiding this comment.
There is only one supported version in this entire file, dispite that I converted them all to a range!
| doesNotReject: { [READ]: { supported: "10.0.0" } }, | ||
| notDeepStrictEqual: { [READ]: { supported: "4.0.0" } }, | ||
| rejects: { [READ]: { supported: "10.0.0" } }, | ||
| [READ]: { supported: ["9.9.0", "8.13.0"] }, |
Author
There was a problem hiding this comment.
This is just a little simpler to generate :)
aladdin-add
approved these changes
Jan 29, 2024
aladdin-add
left a comment
aladdin-add
left a comment
There was a problem hiding this comment.
LGTM, hopefully it will help us to automate this information.
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am aiming to improve the generating of the
node:module definitions. I have done this by normalising the properties toexperimental,supported,deprecated.