feat: Add builtins check for ES2021 to no-unsupported-features/es-bui…

…ltins rule (#153) the change was borrowed from mysticatea#284 credits goes to @ota-meshi. :) Signed-off-by: 唯然 <weiran.zsd@outlook.com>
eslint-community · Dec 20, 2023 · 15a5850 · 15a5850
1 parent 6835a10
commit 15a5850
Show file tree

Hide file tree

Showing 3 changed files with 153 additions and 0 deletions.
diff --git a/docs/rules/no-unsupported-features/es-builtins.md b/docs/rules/no-unsupported-features/es-builtins.md
@@ -48,6 +48,13 @@ The `"ignores"` option accepts an array of the following strings.
 
 <details>
 
+**ES2021:**
+
+- `"AggregateError"`
+- `"Promise.any"`
+- `"WeakRef"`
+- `"FinalizationRegistry"`
+
 **ES2020:**
 
 - `"BigInt"`

diff --git a/lib/rules/no-unsupported-features/es-builtins.js b/lib/rules/no-unsupported-features/es-builtins.js
@@ -14,13 +14,19 @@ const getConfiguredNodeVersion = require("../../util/get-configured-node-version
 
 const trackMap = {
     globals: {
+        AggregateError: {
+            [READ]: { supported: "15.0.0" },
+        },
         Array: {
             from: { [READ]: { supported: "4.0.0" } },
             of: { [READ]: { supported: "4.0.0" } },
         },
         BigInt: {
             [READ]: { supported: "10.4.0" },
         },
+        FinalizationRegistry: {
+            [READ]: { supported: "14.6.0" },
+        },
         Map: {
             [READ]: { supported: "0.12.0" },
         },
@@ -67,6 +73,7 @@ const trackMap = {
         Promise: {
             [READ]: { supported: "0.12.0" },
             allSettled: { [READ]: { supported: "12.9.0" } },
+            any: { [READ]: { supported: "15.0.0" } },
         },
         Proxy: {
             [READ]: { supported: "6.0.0" },
@@ -123,6 +130,9 @@ const trackMap = {
         WeakMap: {
             [READ]: { supported: "0.12.0" },
         },
+        WeakRef: {
+            [READ]: { supported: "14.6.0" },
+        },
         WeakSet: {
             [READ]: { supported: "0.12.0" },
         },

diff --git a/tests/lib/rules/no-unsupported-features/es-builtins.js b/tests/lib/rules/no-unsupported-features/es-builtins.js
@@ -72,6 +72,31 @@ ruleTester.run(
     "no-unsupported-features/es-builtins",
     rule,
     concat([
+        {
+            keyword: "AggregateError",
+            valid: [
+                {
+                    code: "if (error instanceof AggregateError) {}",
+                    options: [{ version: "15.0.0" }],
+                },
+            ],
+            invalid: [
+                {
+                    code: "if (error instanceof AggregateError) {}",
+                    options: [{ version: "14.0.0" }],
+                    errors: [
+                        {
+                            messageId: "unsupported",
+                            data: {
+                                name: "AggregateError",
+                                supported: "15.0.0",
+                                version: "14.0.0",
+                            },
+                        },
+                    ],
+                },
+            ],
+        },
         {
             keyword: "Array.from",
             valid: [
@@ -185,6 +210,31 @@ ruleTester.run(
                 },
             ],
         },
+        {
+            keyword: "FinalizationRegistry",
+            valid: [
+                {
+                    code: "new FinalizationRegistry(() => {})",
+                    options: [{ version: "14.6.0" }],
+                },
+            ],
+            invalid: [
+                {
+                    code: "new FinalizationRegistry(() => {})",
+                    options: [{ version: "14.5.0" }],
+                    errors: [
+                        {
+                            messageId: "unsupported",
+                            data: {
+                                name: "FinalizationRegistry",
+                                supported: "14.6.0",
+                                version: "14.5.0",
+                            },
+                        },
+                    ],
+                },
+            ],
+        },
         {
             keyword: "Map",
             valid: [
@@ -1209,6 +1259,49 @@ ruleTester.run(
                 },
             ],
         },
+        {
+            keyword: "Promise.any",
+            valid: [
+                {
+                    code: "(function(Promise) { Promise.any }(a))",
+                    options: [{ version: "14.0.0" }],
+                },
+                {
+                    code: "Promise.any",
+                    options: [{ version: "15.0.0" }],
+                },
+            ],
+            invalid: [
+                {
+                    code: "Promise.any",
+                    options: [{ version: "14.0.0" }],
+                    errors: [
+                        {
+                            messageId: "unsupported",
+                            data: {
+                                name: "Promise.any",
+                                supported: "15.0.0",
+                                version: "14.0.0",
+                            },
+                        },
+                    ],
+                },
+                {
+                    code: "function wrap() { Promise.any }",
+                    options: [{ version: "14.0.0" }],
+                    errors: [
+                        {
+                            messageId: "unsupported",
+                            data: {
+                                name: "Promise.any",
+                                supported: "15.0.0",
+                                version: "14.0.0",
+                            },
+                        },
+                    ],
+                },
+            ],
+        },
         {
             keyword: "Proxy",
             valid: [
@@ -2006,6 +2099,49 @@ ruleTester.run(
                 },
             ],
         },
+        {
+            keyword: "WeakRef",
+            valid: [
+                {
+                    code: "(function(WeakRef) { WeakRef }(a))",
+                    options: [{ version: "14.5.0" }],
+                },
+                {
+                    code: "WeakRef",
+                    options: [{ version: "14.6.0" }],
+                },
+            ],
+            invalid: [
+                {
+                    code: "WeakRef",
+                    options: [{ version: "14.5.0" }],
+                    errors: [
+                        {
+                            messageId: "unsupported",
+                            data: {
+                                name: "WeakRef",
+                                supported: "14.6.0",
+                                version: "14.5.0",
+                            },
+                        },
+                    ],
+                },
+                {
+                    code: "function wrap() { WeakRef }",
+                    options: [{ version: "14.5.0" }],
+                    errors: [
+                        {
+                            messageId: "unsupported",
+                            data: {
+                                name: "WeakRef",
+                                supported: "14.6.0",
+                                version: "14.5.0",
+                            },
+                        },
+                    ],
+                },
+            ],
+        },
         {
             keyword: "WeakSet",
             valid: [