Skip to content

chore: add pre-commit hook with lint-staged #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

chore: add pre-commit hook with lint-staged #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d87f375
chore: add pre-commit hook with lint-staged
aladdin-add Oct 23, 2025
d1504c1
Remove 'release' script and reorder 'prepare'
aladdin-add Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx lint-staged
3 changes: 1 addition & 2 deletions .npmpackagejsonlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"prefer-alphabetical-devDependencies": "error",
"prefer-alphabetical-optionalDependencies": "error",
"prefer-alphabetical-scripts": "error",
"prefer-caret-version-dependencies": "error",
"prefer-caret-version-devDependencies": "error"
Copy link
Member

@bmish bmish Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule takes options of packages to ignore.

Copy link
Contributor Author

@aladdin-add aladdin-add Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so, I just haven't read its documentation.

"prefer-caret-version-dependencies": "error"
}
}
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CHANGELOG.md
25 changes: 6 additions & 19 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"lint:js": "eslint --cache --ignore-pattern \"**/*.md\" --flag unstable_native_nodejs_ts_config",
"lint:js-docs": "eslint --no-inline-config \"**/*.md\" --flag unstable_native_nodejs_ts_config",
"lint:package-json": "npmPkgJsonLint .",
"release": "release-it",
"prepare": "husky install",
"test": "vitest run --coverage",
"test:remote": "eslint-remote-tester",
"typecheck": "tsc",
Expand Down Expand Up @@ -62,7 +62,7 @@
"@types/estraverse": "^5.1.7",
"@types/estree": "^1.0.8",
"@types/lodash": "^4.17.18",
"@types/node": "^20.19.0",
"@types/node": "^20.19.23",
"@typescript-eslint/parser": "^8.39.0",
"@typescript-eslint/utils": "^8.39.0",
"@vitest/coverage-istanbul": "^3.2.4",
Expand All @@ -82,7 +82,7 @@
"markdownlint-cli": "^0.43.0",
"npm-package-json-lint": "^8.0.0",
"npm-run-all2": "^7.0.1",
"prettier": "^3.6.2",
"prettier": "3.6.2",
"release-it": "^17.2.0",
"tsdown": "^0.13.3",
"typescript": "^5.9.2",
Expand All @@ -95,21 +95,8 @@
"engines": {
"node": "^20.19.0 || ^22.13.1 || >=24.0.0"
},
"release-it": {
"git": {
"commitMessage": "chore: release v${version}"
},
"plugins": {
"@release-it/conventional-changelog": {
"preset": "conventionalcommits",
"infile": "CHANGELOG.md"
}
},
"github": {
"release": true
},
"npm": {
"skipChecks": true
}
"lint-staged": {
"*.{js,ts}": "eslint --cache --fix",
"*.{js,ts,md}": "prettier --write"
}
}