Skip to content

Conversation

@bmish
Copy link
Member

@bmish bmish commented Oct 24, 2021

This rule needs to detect the name of each rule from the file path. It previously failed to detect the rule name correctly when the rule file used extensions besides .js like .ts for TypeScript rules. As a result, the rule would enforce the incorrect URL.

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@aladdin-add aladdin-add merged commit 6a09dbe into eslint-community:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants