Fix crash in no-nonstandard-*-properties rules (#234)

eslint-community · Nov 21, 2024 · 95dc006 · 95dc006
1 parent 92f5f75
commit 95dc006
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/util/get-property-key-value.js b/lib/util/get-property-key-value.js
@@ -55,9 +55,10 @@ function getPropertyKeyValue(node, initialScope) {
  */
 function getStaticKeyValue(node, initialScope) {
     const value = getStaticValue(node, initialScope)
-    return value && typeof value.value === "symbol"
-        ? value.value
-        : String(value.value)
+    return (
+        value &&
+        (typeof value.value === "symbol" ? value.value : String(value.value))
+    )
 }
 
 module.exports = { getPropertyKeyValue }
diff --git a/tests/lib/rules/no-nonstandard-array-prototype-properties.js b/tests/lib/rules/no-nonstandard-array-prototype-properties.js
@@ -22,6 +22,8 @@ new RuleTester().run(ruleId, rule, {
         { code: "['A'].unknown()", options: [{ allow: ["unknown"] }] },
         // Test for https://github.com/eslint-community/eslint-plugin-es-x/issues/223
         "for (const { x } of foo) {}",
+        // Test for https://github.com/eslint-community/eslint-plugin-es-x/issues/233
+        "['A'][unknown];",
     ],
     invalid: [
         {