-
Notifications
You must be signed in to change notification settings - Fork 438
Add support for SSLKEYLOGFILE #4634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CircleCI results for 159d78b elasticsearch_and_cassandra_latest / elasticsearch_and_cassandra_mnesia / 5ac3115 small_tests_legacy / small_tests / 5ac3115 small_tests_latest / small_tests / 5ac3115 small_tests_latest_arm64 / small_tests / 5ac3115 ldap_mnesia_legacy / ldap_mnesia / 5ac3115 ldap_mnesia_latest / ldap_mnesia / 5ac3115 dynamic_domains_mysql_redis_latest / mysql_redis / 5ac3115 internal_mnesia_latest / internal_mnesia / 5ac3115 dynamic_domains_pgsql_mnesia_legacy / pgsql_mnesia / 5ac3115 pgsql_cets_latest / pgsql_cets / 5ac3115 mysql_redis_latest / mysql_redis / 5ac3115 cockroachdb_cets_latest / cockroachdb_cets / 5ac3115 pgsql_mnesia_latest / pgsql_mnesia / 5ac3115 pgsql_mnesia_legacy / pgsql_mnesia / 5ac3115 dynamic_domains_pgsql_mnesia_latest / pgsql_mnesia / 5ac3115 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4634 +/- ##
==========================================
+ Coverage 86.03% 86.04% +0.01%
==========================================
Files 566 566
Lines 33926 33926
==========================================
+ Hits 29187 29192 +5
+ Misses 4739 4734 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support for logging TLS session secrets to a file via the SSLKEYLOGFILE environment variable when tls.keep_secrets = true, enabling external tools (e.g., Wireshark) to decrypt captured TLS traffic.
Changes:
- Extend TLS config schema and parser to accept
keep_secrets. - Implement
SSLKEYLOGFILE-driven key logging injust_tls. - Add documentation and an end-to-end big test verifying that secrets are written.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/config_parser_SUITE.erl |
Adds config-parser coverage for the new tls.keep_secrets option. |
src/just_tls.erl |
Implements conditional TLS key logging based on keep_secrets + SSLKEYLOGFILE. |
src/config/mongoose_config_spec.erl |
Adds keep_secrets to the TLS(common) config spec. |
doc/listeners/listen-c2s.md |
Documents listen.c2s.tls.keep_secrets and its security implications. |
big_tests/tests/connect_SUITE.erl |
Adds a new test group and test case to verify keylog output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chrzaszcz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments.
chrzaszcz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks for the corrections 👍
This PR adds support for the SSLKEYLOGFILE environment variable. Enabling
tls.keep_secretsis required for this to work.