Add dynamic domains support to mod_event_pusher and related modules #4629

tomaszwojcikowski · 2026-01-21T14:52:20Z

Implemented supported_features/0 callback in mod_event_pusher, mod_event_pusher_http, mod_event_pusher_push, mod_event_pusher_rabbit, and mod_event_pusher_sns.
Added remove_domain/2 handler in mod_event_pusher_push and its backends for domain removal.
Updated documentation to reflect compatibility with dynamic domains and removed warnings from Modules.md and mod_event_pusher.md.
Added test suites for dynamic domains in dynamic_domains.spec.

This PR addresses #

Proposed changes include:

describe the functionality changes
describe new or updated tests
describe changes to the documentation

- Implemented `supported_features/0` callback in mod_event_pusher, mod_event_pusher_http, mod_event_pusher_push, mod_event_pusher_rabbit, and mod_event_pusher_sns. - Added `remove_domain/2` handler in mod_event_pusher_push and its backends for domain removal. - Updated documentation to reflect compatibility with dynamic domains and removed warnings from Modules.md and mod_event_pusher.md. - Added test suites for dynamic domains in dynamic_domains.spec.

mongoose-im · 2026-01-21T15:01:30Z

CircleCI results for 969a63f

elasticsearch_and_cassandra_latest / elasticsearch_and_cassandra_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0

ldap_mnesia_latest / ldap_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 2395 / Failed: 0 / User-skipped: 1415 / Auto-skipped: 0

small_tests_legacy / small_tests / cf55d1c
Reports root / small

small_tests_latest / small_tests / cf55d1c
Reports root / small

small_tests_latest_arm64 / small_tests / cf55d1c
Reports root / small

ldap_mnesia_legacy / ldap_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 2395 / Failed: 0 / User-skipped: 1415 / Auto-skipped: 0

internal_mnesia_latest / internal_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 2543 / Failed: 0 / User-skipped: 1267 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_latest / pgsql_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 5349 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

dynamic_domains_mysql_redis_latest / mysql_redis / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 5314 / Failed: 0 / User-skipped: 157 / Auto-skipped: 0

pgsql_cets_latest / pgsql_cets / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 5397 / Failed: 0 / User-skipped: 202 / Auto-skipped: 0

cockroachdb_cets_latest / cockroachdb_cets / cf55d1c
Status: 🔴 Failed
Reports root/ big
OK: 5396 / Failed: 1 / User-skipped: 202 / Auto-skipped: 0

local_iq_SUITE:iq_group:process_iq_works_across_multiple_nodes

{error,{test_case_failed,timeout_waiting_for_result}}

Report log

mysql_redis_latest / mysql_redis / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 5693 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

pgsql_mnesia_legacy / pgsql_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 5700 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_latest / pgsql_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 5700 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_legacy / pgsql_mnesia / cf55d1c
Status: 🟢 Passed
Reports root/ big
OK: 5349 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

codecov · 2026-01-21T15:03:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.09%. Comparing base (31bfe0b) to head (cf55d1c).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4629      +/-   ##
==========================================
+ Coverage   86.05%   86.09%   +0.04%     
==========================================
  Files         566      566              
  Lines       33926    33947      +21     
==========================================
+ Hits        29195    29228      +33     
+ Misses       4731     4719      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ed functions for dynamic domain handling

…ability

…tart_hook_handler and rpc_stop_hook_handler

…hook_handler and rpc_stop_hook_handler

… RDBMS backends

fen-pl

Some open questions plus improvement requests for tests.

src/event_pusher/mod_event_pusher_push_mnesia.erl

fen-pl · 2026-01-29T11:33:15Z

src/event_pusher/mod_event_pusher_push_rdbms.erl

                             "WHERE owner_jid = ? AND node = ? AND pubsub_jid = ?">>),
+    mongoose_rdbms:prepare(event_pusher_push_remove_domain, event_pusher_push_subscription,
+                           [owner_jid],
+                           <<"DELETE FROM event_pusher_push_subscription WHERE owner_jid LIKE ?">>),


Not that happy about the potential performance implications here too but adding a new column and asking users to migrate the table might be an overkill here...

fen-pl · 2026-01-29T11:37:52Z

test/mod_event_pusher_push_SUITE.erl

+    {ok, Services1} = mod_event_pusher_push_mnesia:get_publish_services(?HOST_TYPE, User1),
+    {ok, Services2} = mod_event_pusher_push_mnesia:get_publish_services(?HOST_TYPE, User2),
+    ?assertEqual(1, length(Services1)),
+    ?assertEqual(1, length(Services2)),


Assertions on length carry virtually no debug information in case of failure.

Suggested change

{ok, Services1} = mod_event_pusher_push_mnesia:get_publish_services(?HOST_TYPE, User1),

{ok, Services2} = mod_event_pusher_push_mnesia:get_publish_services(?HOST_TYPE, User2),

?assertEqual(1, length(Services1)),

?assertEqual(1, length(Services2)),

{ok, [_]} = mod_event_pusher_push_mnesia:get_publish_services(?HOST_TYPE, User1),

{ok, [_]} = mod_event_pusher_push_mnesia:get_publish_services(?HOST_TYPE, User2),

fen-pl · 2026-01-29T11:38:34Z

test/mod_event_pusher_push_SUITE.erl

+    ?assertEqual([], ServicesAfter1),
+    ?assertEqual([], ServicesAfter2).
+
+mnesia_remove_domain_keeps_other_domain_subscriptions(_Config) ->


Since we care about this case here, it should be also tested for RDBMS.

…ertMatch for better readability

src/event_pusher/mod_event_pusher_push_rdbms.erl

fen-pl · 2026-01-30T13:05:13Z

test/mod_event_pusher_push_SUITE.erl

+%% Test cases - RDBMS backend
+%%--------------------------------------------------------------------
+
+rdbms_remove_domain_calls_execute_successfully(_Config) ->


This is not an RDBMS variant for _keeps_other_domain_subscriptions

fen-pl · 2026-02-03T09:06:35Z

src/event_pusher/mod_event_pusher_push_rdbms.erl

+
+-spec select_domain_batch(mongooseim:host_type(), binary(), pos_integer()) -> [jid:literal_jid()].
+select_domain_batch(HostType, LikePattern, BatchSize) ->
+    {selected, Rows} = mongoose_rdbms:execute_successfully(


I'm pretty sure this can be rewritten into WITH ... DELETE statement - it will significantly reduce round trips here.

fen-pl · 2026-02-03T09:06:54Z

src/event_pusher/mod_event_pusher_push_rdbms.erl

+    %% Users are stored as 'user@domain' in owner_jid, so we use LIKE '%@domain'
+    LikePattern = <<"%@", Domain/binary>>,
+    remove_domain_batches(HostType, LikePattern, ?REMOVE_DOMAIN_BATCH_SIZE,
+                          fun select_domain_batch/3,


This approach seems forced only to conform with the current testing approach. I'd even consider moving this check to big tests. If not, it's better to use meck to mock mongoose_rdbms call.

tomasz-wojcikowski added 2 commits January 21, 2026 16:49

Refactor iq_handler to support additional parameters and update relat…

23d647e

…ed functions for dynamic domain handling

Fix mkdocs warnings: remove links to source files

8971c7b

tomaszwojcikowski force-pushed the tomasz/mim-2559-event-pusher-dynamic-domains branch from 37b2015 to 8971c7b Compare January 21, 2026 16:18

tomasz-wojcikowski added 6 commits January 22, 2026 12:03

Fix formatting in maybe_retry_remove_archive function for better read…

f4845bd

…ability

Refactor push_notifications handler to use dynamic host type in rpc_s…

a05ccd4

…tart_hook_handler and rpc_stop_hook_handler

Enhance push notifications by adding HostType parameter to rpc_start_…

8f7f7ab

…hook_handler and rpc_stop_hook_handler

Implement domain removal in push subscription handlers for Mnesia and…

b043038

… RDBMS backends

Merge branch 'master' into tomasz/mim-2559-event-pusher-dynamic-domains

0084778

Add tests for push subscription removal in mod_event_pusher_push

3facea5

tomaszwojcikowski marked this pull request as ready for review January 26, 2026 09:28

fen-pl self-requested a review January 29, 2026 09:28

fen-pl requested changes Jan 29, 2026

View reviewed changes

tomasz-wojcikowski added 3 commits January 29, 2026 14:20

Refactor tests for domain removal in mod_event_pusher_push to use ass…

aeb108c

…ertMatch for better readability

Add RDBMS backend tests for domain removal in mod_event_pusher_push

ad4a2df

Implement batch processing for domain removal in RDBMS backend

8c9c61f

fen-pl reviewed Jan 30, 2026

View reviewed changes

Add tests for RDBMS domain removal and subscription preservation

ae3d012

fen-pl requested changes Feb 3, 2026

View reviewed changes

Refactor RDBMS domain removal to simplify logic and improve performance

cf55d1c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dynamic domains support to mod_event_pusher and related modules #4629

Add dynamic domains support to mod_event_pusher and related modules #4629

Uh oh!

tomaszwojcikowski commented Jan 21, 2026

Uh oh!

mongoose-im commented Jan 21, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

fen-pl left a comment

Uh oh!

Uh oh!

fen-pl Jan 29, 2026

Uh oh!

fen-pl Jan 29, 2026

Uh oh!

fen-pl Jan 29, 2026

Uh oh!

Uh oh!

fen-pl Jan 30, 2026

Uh oh!

fen-pl Feb 3, 2026

Uh oh!

fen-pl Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add dynamic domains support to mod_event_pusher and related modules #4629

Are you sure you want to change the base?

Add dynamic domains support to mod_event_pusher and related modules #4629

Uh oh!

Conversation

tomaszwojcikowski commented Jan 21, 2026

Uh oh!

mongoose-im commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fen-pl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fen-pl Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

fen-pl Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

fen-pl Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fen-pl Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

fen-pl Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

fen-pl Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mongoose-im commented Jan 21, 2026 •

edited

Loading

codecov bot commented Jan 21, 2026 •

edited

Loading