Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19: serializers & views for sessions/APIAccess management #20

Merged
merged 8 commits into from
Jan 20, 2022

Conversation

eshaan7
Copy link
Owner

@eshaan7 eshaan7 commented Sep 21, 2021

  • finalize views, serializer, urls, settings
  • adjust example_project for new changes
  • new test cases
  • docs

@eshaan7 eshaan7 linked an issue Sep 21, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #20 (0d97ad4) into main (384d89c) will increase coverage by 3.26%.
The diff coverage is 100.00%.

❗ Current head 0d97ad4 differs from pull request most recent head f2ef6dc. Consider uploading reports for the commit f2ef6dc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   87.27%   90.54%   +3.26%     
==========================================
  Files          13       13              
  Lines         275      370      +95     
  Branches       41       24      -17     
==========================================
+ Hits          240      335      +95     
  Misses         28       28              
  Partials        7        7              
Impacted Files Coverage Δ
durin/settings.py 15.38% <ø> (ø)
durin/serializers.py 100.00% <100.00%> (ø)
durin/urls.py 100.00% <100.00%> (ø)
durin/views.py 100.00% <100.00%> (ø)
example_project/permissions.py 100.00% <100.00%> (ø)
example_project/views.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b3864...f2ef6dc. Read the comment docs.

@eshaan7 eshaan7 force-pushed the dev-sessions-19 branch 5 times, most recently from 25d239e to dae5aaf Compare September 21, 2021 15:14
@eshaan7 eshaan7 changed the title Fixes #19: Sessions/APIAccess Management Fixes #19: serializers & views for sessions/APIAccess management Sep 21, 2021
@eshaan7 eshaan7 marked this pull request as ready for review January 20, 2022 12:19
Copy link

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought. View full project report here.

tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
tests/test_views.py Show resolved Hide resolved
@eshaan7 eshaan7 merged commit d684fb7 into main Jan 20, 2022
@eshaan7 eshaan7 deleted the dev-sessions-19 branch January 20, 2022 12:20
@eshaan7 eshaan7 restored the dev-sessions-19 branch January 20, 2022 12:20
@eshaan7 eshaan7 deleted the dev-sessions-19 branch February 16, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session management
1 participant