forked from grafana/loki
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CI] improvement of code coverage check (grafana#7428)
**What this PR does / why we need it**: changed the check step to compare code coverage with `target` branch, not with `main`. Previously, it compared code coverage with coverage in the `main` branch. to do this, Drone checked out `main` branch and tried to run the tests to report the coverage. Also, Drone ran the tests on the current branch, and after that compared the results and reported them to PR as a comment. However, if the PR is opened against not `main` branch, for example, against `release-2.6.x` branch, drone tried to compare coverage between the source branch from PR and `main`. However, `main` might contain breaking changes that prevent Drone from compiling the sources or from running the tests successfully. Last time, it was Go version. Loki in `main` branch was migrated to go1.19 and `loki-build-image` was updated. however, Drone CI on release branch ran the pipeline on old `loki-build-image` that was not able to compile the Loki from `main` branch.
- Loading branch information
1 parent
a508d69
commit 30fe6b9
Showing
2 changed files
with
33 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters