Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Avoid unnecessary fuzzy search" #27

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

esentis
Copy link
Owner

@esentis esentis commented Feb 25, 2023

Reverts #26

Copy link
Owner Author

@esentis esentis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anqit ||== is not recognized :/

@esentis esentis merged commit a5e73d0 into develop Feb 25, 2023
@esentis esentis deleted the revert-26-avoid_unnecessary_fuzzy_search branch February 25, 2023 17:14
@anqit
Copy link
Contributor

anqit commented Feb 25, 2023

Yeah sorry about that, I was told that was the right thing in the dart issue I mentioned in the previous PR so just updated the file directly in github. I should have checked first.

esentis added a commit that referenced this pull request Mar 5, 2023
* ♻️ 🎨 Improves structure & refactors methods

* 📝 Documents changes

* ⬆️ Bumps version to 2.3.6

* call remove once; other small fixes (#22)

* 📝 Updates CHANGELOG

* ✨ Adds pickedItemsContainerBuilder

Closes #23

* ⬆️ Bumps version to 2.3.7

* 📝 Documents changes

* Allow setting controllers and a couple other customizations (#24)

* providable nodes and controllers

* customize hint text and allow clearing field

* undo input decoration

* use custom picked items builder for empty lists also

* re-add custom input decoration

* ⬆️ Bumps version to 2.4.0

* 📝 Documents changes

* 🤡 Tweaks example code

* 💥 ✨ Refactors showed items with lazy loading

* 🐛 Adds missed shrinkwrap

* ⬆️ Bumps version to 2.4.1

* 📝 Documents changes

* fix short-circuiting due to dart-lang/language#2864 (#25)

* Avoid unnecessary fuzzy search (#26)

* fix short-circuiting due to dart-lang/language#2864

* update operator

turns out the "double" version of the operators does short-circuit

* Revert "Avoid unnecessary fuzzy search (#26)" (#27)

This reverts commit 7aaed22.

* ⬆️ Bumps version to 2.4.2

* 📝 Updates CHANGELOG

* fix: outerContainerColor (#28)

* fix: outerContainerColor

* fix: outerContainerDecoration

* ⬆️ Bumps version to 2.4.3

* 📝Updates CHANGELOG

* 🐛 Resolves decoration discrepancies

---------

Co-authored-by: anqit <anqit.praqash@gmail.com>
Co-authored-by: Julia Bulgakova <37380842+Luvti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants