Remove warning about ordering issue #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pointing this out. That issue is now fixed so your change here looks good. There is still a problem with CSS-in-JS imports and code splitting, but perhaps that warning belongs on the splitting flag instead. In that case we can just remove this warning. I'll try that after landing this change. Edit: Never mind. I think the problem with CSS-in-JS imports and code splitting was actually fixed by that change you linked to. So no mention of that issue is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this is theoretically fixed as of evanw/esbuild#1293, maybe we can remove the import order warning. Alternatively we could update it to reference the specific version that the issue was fixed.