Skip to content

Conversation

@tjorim
Copy link
Contributor

@tjorim tjorim commented Aug 5, 2024

Proposed Changes

I got really confused trying to check this new async lib (found here).
This repo is named python-tado but the pip package is actually tadoasync.
Repo of 'original' library is named PyTado but published on PyPI as python-tado...
Following this readme would have installed the other library.

@erwindouna
Copy link
Owner

Thanks for your keen eye!

@erwindouna erwindouna merged commit 278ae33 into erwindouna:main Aug 5, 2024
@tjorim
Copy link
Contributor Author

tjorim commented Aug 5, 2024

Is the repo name final? Might be confusing for developers as it is now.

@tjorim tjorim deleted the patch-1 branch August 5, 2024 15:32
@erwindouna
Copy link
Owner

Is the repo name final? Might be confusing for developers as it is now.

I would say so, it changed two times and right this name is free and matching its purpose. I have no intention to change it again.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
@erwindouna erwindouna added the maintenance Generic maintenance tasks label Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintenance Generic maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants