Potential fix for code scanning alert no. 13: DOM text reinterpreted as HTML #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…as HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
erwindon
force-pushed
the
alert-autofix-13
branch
from
cb845b8 to
bab4827
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/erwindon/SaltGUI/security/code-scanning/13
To fix the issue, ensure that all untrusted data concatenated into the
htmlvariable is properly escaped using the_escapeHtmlmethod. This involves identifying all instances where untrusted data flows intohtmland applying_escapeHtmlto sanitize the data. Specifically, thecmdvariable and any other untrusted inputs should be escaped before being used in HTML strings.Changes are required in the following areas:
cmdis escaped before being concatenated intohtmlon line 313.htmland apply_escapeHtmlas needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.