Skip to content

Potential fix for code scanning alert no. 13: DOM text reinterpreted as HTML #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwindon merged 1 commit into from
Jun 10, 2025
Merged

Potential fix for code scanning alert no. 13: DOM text reinterpreted as HTML #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions saltgui/static/scripts/Documentation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export class Documentation {

// title line
let html = "";
html += "<h3>Documentation for '" + cmd.join(".").replace(/^modules[.]/, "") + "':</h3>";
html += "<h3>Documentation for '" + Documentation._escapeHtml(cmd.join(".").replace(/^modules[.]/, "")) + "':</h3>";

// level 0
html += "<p><a href='" + Documentation.DOCUMENTATION_URL + "' target='_blank' rel='noopener'>Salt Module Reference</a>" + Documentation.EXTERNAL_LINK + "</p>";
Expand All @@ -266,13 +266,13 @@ export class Documentation {
// Function getKeywordFragments makes sure that
// the cmd array has at least one element.
// The default is "modules"
let pageTitle = "All '" + cmd[0] + "' modules";
let pageTitle = "All '" + Documentation._escapeHtml(cmd[0]) + "' modules";
if (cmd[0] === "modules") {
// the page title is different for this page
// the link to the page must use the same title
pageTitle = "All 'execution' modules";
}
html += "<p><a href='" + Documentation.DOCUMENTATION_URL + cmd[0] + "/all/index.html' target='_blank' rel='noopener'>" + pageTitle + "</a>" + Documentation.EXTERNAL_LINK + "</p>";
html += "<p><a href='" + Documentation.DOCUMENTATION_URL + Documentation._escapeHtml(cmd[0]) + "/all/index.html' target='_blank' rel='noopener'>" + Documentation._escapeHtml(pageTitle) + "</a>" + Documentation.EXTERNAL_LINK + "</p>";

// When the module is a virtual module, we want
// to show all relevant concrete modules
Expand Down