Skip to content

Conversation

@erwindon
Copy link
Owner

Is your feature request related to a problem? Please describe.
I takes time to scroll on SaltGui even if most of the state_id have not been updated on the minions.

Describe the solution you'd like
It could be great to be able to have a toggle in order not to show state_ids that have not been updated.

Describe alternatives you've considered
Keep scrolling

Additional context
We use SaltGui to manage dozens of minions, each made of os dozens of state_ids :)

@erwindon
Copy link
Owner

the question is about highstate output as seen on the Job page, isn't it?
(and not about the output of the Highstate screen)

@cedricmaunoury
Copy link
Author

Yes. For me, there is (at least) 2 places where it could be interesting : the form where you can run commands on minions (available through the « > » button on the top right of the index page) & the last jobs run through the GUI. Thanks for your quick feedback 😊

@erwindon
Copy link
Owner

ok, understood.
no real changes will be made to the direct-output panel.
but since there is a lot of shared code between the 2, it may still benefit from changes on the Job screen.

@erwindon
Copy link
Owner

The Job screen (when viewing highstate output) already has some helpful features.
It is possible:

  • to collapse the output of all minions, leaving just the minion names and a list of colored balls representing the individual states; and
  • to click on one of the colored balls, so the screen will scroll down and temporary highlight the corresponding task, the tasks for that minion will be shown again in the process. the task-block will flash to indicate its location; and
  • to click on the output of any task, so the screen will scroll back to the top of the task list for that minion, allowing quick selection of the next one.

are you already using these features?

@cedricmaunoury
Copy link
Author

Finally, the goal would be to be able to set --state-verbose=false in the GUI.

I am using these features but it is still "massive clicking" to prevent seeing "useless" informations.

@erwindon
Copy link
Owner

SaltGUI has one hidden feature...

  • use CTRL-CLICK on the SaltGUI logo to get access to an otherwise hidden options page. you can change state-verbose there for the duration of the session
  • use variable saltgui_state_verbose: false in the /etc/salt/master file to start with that value. made that a different variable then state_verbose so that it affects the view in SaltGUI only, not how it stored or visible to commandline users

@cedricmaunoury
Copy link
Author

A new hidden world is now available. Thank you :)

My 2 cts : It may be more "User friendly" to give access to all these options through a standard button.

Thanks again for this GUI for Salt !

@erwindon
Copy link
Owner

My 2 cts : It may be more "User friendly" to give access to all these options through a standard button.

I'll add a tooltip "click for internal details" to the logo
The documentation is already in https://github.com/erwindon/SaltGUI#settings-and-statistics

@erwindon
Copy link
Owner

migrated issue to PR using hub pull-request -i 543

@erwindon
Copy link
Owner

  • tooltip added to logo
  • added warning that settings in "Options" are for the current session only

@cedricmaunoury
can you try the SaltGUI version from this branch? and leave whatever comments you have on it?

@erwindon erwindon assigned cedricmaunoury and unassigned erwindon Oct 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erwindon
Copy link
Owner

@cedricmaunoury
ping?

@cedricmaunoury
Copy link
Author

@erwindon Sorry, I have not been able to test it yet in our environment. From this feature request, we decided to put state_verbose: False in our minions configuration to always filter the output.

@erwindon
Copy link
Owner

@cedricmaunoury
the only change now made in this PR is to make the Options screen less secret (and no changes related to highstates).
there is now a tooltip on the SaltGUI logo that explains that ctrl-click navigates to the Options page.
also based on your comment:

My 2 cts : It may be more "User friendly" to give access to all these options through a standard button.

that's why I asked for your opinion this :-)

@cedricmaunoury
Copy link
Author

It is a good improvement 👍

@erwindon erwindon merged commit 324be5e into master Oct 26, 2023
@erwindon erwindon deleted the optionspage branch October 26, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants