Skip to content

Conversation

@AntonOvseenko
Copy link
Contributor

Example. Before changes id was: /data/saltgui id=Salt-Gui%20-%20download%20and%20extract%20archive (from projects/ati/salt-master/ubuntu.sls)
After changes: /data/saltgui id=[Salt-Gui - download and extract archive] (from projects/ati/salt-master/ubuntu.sls)

Example. Before changes id was: /data/saltgui id=Salt-Gui%20-%20download%20and%20extract%20archive (from projects/ati/salt-master/ubuntu.sls)
After changes: /data/saltgui id=[Salt-Gui - download and extract archive] (from projects/ati/salt-master/ubuntu.sls)
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erwindon
Copy link
Owner

@AntonOvseenko
great find!
that encoding action should not have been there.
I never noticed it because I personally stick to 'identifier' naming conventions.
I verified that all other calls to encodeURIComponent are in a proper context.

@erwindon erwindon self-assigned this Apr 14, 2023
@erwindon erwindon merged commit 3b8045f into erwindon:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants