Augment: IHasRandomValueGenerator #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm (not) sorry
Added an unmanaged implementation IHasUnmanagedRandomValueGenerator
Aragas
changed the title
Aragas
changed the title
erri120
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Besides having to adapt this code to latest main, I don't think IHasRandomValueGenerator should have a TRandom type argument. 99.999999% of the time it's going to be System.Random. If you remove the type argument, we can also use Random.Shared instead of instantiating a new Random object every time.
src/TransparentValueObjects.Augments/IHasRandomValueGenerator.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # tests/TransparentValueObjects.Tests/ValueObjectIncrementalSourceGeneratorTests/BaseTests.cs
Removed GenerateRandomValue Added GetRandom
|
Should be up to date now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm (not) sorry
We also need tests for unmanaged/int types