Ignore optional Hex package dependencies #2982
Conversation
Filter out dependencies marked as optional in Hex package metadata. Rebar3 does not support optional dependencies, so they should not be fetched or compiled. This fixes issues where optional Mix-only transitive dependencies would cause build failures. Bump PACKAGE_INDEX_VERSION to invalidate existing caches. Fixes erlang#2977
| -define(DEFAULT_COMPILER_SOURCE_FORMAT, relative). | ||
| -define(DEFAULT_COMPILER_ERROR_FORMAT, rich). % 'minimal' for default values as of 3.23.0 and earlier | ||
| -define(PACKAGE_INDEX_VERSION, 6). | ||
| -define(PACKAGE_INDEX_VERSION, 7). |
There was a problem hiding this comment.
is there a reason we need to bump the package index version? I believe the disk format is the same, the question is just whether we want to refresh what we keep inside or outside of it? Arguably we should be able to reuse the same package version but trigger a fresh build.
I guess it would be for consistency (everyone refreshes their snapshots, behavior is the same across all similar rebar3 builds?)
There was a problem hiding this comment.
@ferd Yes, the format is the same, but we might calculate the requirements differently.
But this whole thing is probably more of an edge case. We can also keep the version and tell people to clear the cache if they run into trouble.
There was a problem hiding this comment.
Yeah to get consistent behavior I think it'd be fine bumping the version. It might mess with some cached images for builds that will need a refresh (if any) but I'd rather do that than seeing people get inconsistent builds (and lock files) from the same rebar3 version based on past fetch history.
ferd
left a comment
ferd
left a comment
There was a problem hiding this comment.
Merging this, will let it simmer a while before cutting a build, letting people find issues if any.
2 participants
Filter out dependencies marked as optional in Hex package metadata. Rebar3 does not support optional dependencies, so they should not be fetched or compiled. This fixes issues where optional Mix-only transitive dependencies would cause build failures.
Bump
PACKAGE_INDEX_VERSIONto invalidate existing caches.I have verified the change with the
purlpackage locally.Fixes #2977