Skip to content

Conversation

@ferd
Copy link
Collaborator

@ferd ferd commented May 24, 2023

I hadn't seen this because all my projects use warnings_as_errors, but the warnings were never properly wired up.

This patch fixes that by adding the proper callbacks and invoking them from the 3 erlang-related compilers we support.

Sample run:

→ rebar3 as test compile
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling revault
===> Compiling maestro
    ┌─ apps/revault/test/id_shim.erl:
    │
 23 │  id_ask(From, To) ->
    │               ╰── Warning: variable 'To' is unused


===> Analyzing applications...
===> Compiling extra_test

This might look a bit like an error but yeah, not a good way to bypass that for now without further re-structuring of the code.

I hadn't seen this because all my projects use warnings_as_errors, but
the warnings were never properly wired up.

This patch fixes that by adding the proper callbacks and invoking them
from the 3 erlang-related compilers we support.
@ferd ferd merged commit c2bcce4 into erlang:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant