Skip to content

FTP: document ftp_extension option #9734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mworrell
Copy link
Contributor

@mworrell mworrell commented Apr 16, 2025

The ftp_extension option was not documented.

It was also removed from the type spec of the ftp:open options.
With OTP 25 it was in the type spec and in (some) release notes, but not in the documentation.

This adds the type spec and the documentation for this useful option.

@kikofernandez kikofernandez added team:PS Assigned to OTP team PS enhancement labels Apr 16, 2025
@IngelaAndin IngelaAndin self-assigned this Apr 23, 2025
@IngelaAndin IngelaAndin changed the base branch from maint-27 to maint April 23, 2025 06:55
@IngelaAndin
Copy link
Contributor

This seems to be an oversight from long ago as it was added in OTP-17. I will check what release to include it in.

@IngelaAndin IngelaAndin changed the base branch from maint to master April 23, 2025 13:40
@IngelaAndin
Copy link
Contributor

IngelaAndin commented Apr 28, 2025

@mworrell would you mind extending the test suite also? As this alas seem to not be tested.

@IngelaAndin IngelaAndin added this to the OTP-28.1 milestone Apr 29, 2025
@IngelaAndin IngelaAndin added the waiting waiting for changes/input from author label May 6, 2025
@IngelaAndin IngelaAndin assigned Whaileee and bmk and unassigned IngelaAndin Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement team:PS Assigned to OTP team PS waiting waiting for changes/input from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants