tty: Fix blocking ReadFile call on Windows #7400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 3 files 183 suites 1h 51m 55s ⏱️ For more details on these failures, see this check. Results for commit 9a0635c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
garazdawi
added
the
testing
garazdawi
force-pushed
the
lukas/erts/fix-blocking-ReadFile-win32
branch
from
1c6eaec to
9a0635c
Compare
When calling ReadFile using blocking semantics on a terminal, the call would block until a line has been entered on the console. This makes it impossible to interact with the process doing the read (to change encoding for example). So we change to using non-blocking (OVERLAPPED) ReadFile when reading from a Console when there is no shell started. Fixes erlang#7261
garazdawi
force-pushed
the
lukas/erts/fix-blocking-ReadFile-win32
branch
from
9a0635c to
2bbeed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling ReadFile using blocking semantics on a terminal, the call would block until a line has been entered on the console. This makes it impossible
to interact with the process doing the read (to change encoding for example).
So we change to using non-blocking (OVERLAPPED) ReadFile when reading from a Console when there is no shell started.
Fixes #7261