Skip to content

Comments

Add missing include statements in in6addr tests#2687

Merged
bmk merged 1 commit intoerlang:maintfrom
AquaGeek:missing-includes
Jul 27, 2020
Merged

Add missing include statements in in6addr tests#2687
bmk merged 1 commit intoerlang:maintfrom
AquaGeek:missing-includes

Conversation

@AquaGeek
Copy link
Contributor

@AquaGeek AquaGeek commented Jul 9, 2020

Compilation is failing on macOS Big Sur due to in6addr_any and in6addr_loopback being redeclared. The underlying issue is that the tests for these are failing due to missing include statements:

conftest.c:197:1: error: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Werror,-Wimplicit-function-declaration]
printf("%d", in6addr_any.s6_addr[16]);
^
conftest.c:197:1: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'

ERL-1306

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2020

CLA assistant check
All committers have signed the CLA.

@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Jul 10, 2020
@garazdawi garazdawi changed the base branch from master to maint July 10, 2020 06:44
@garazdawi garazdawi added fix team:VM Assigned to OTP team VM labels Jul 10, 2020
@garazdawi garazdawi changed the base branch from maint to master July 10, 2020 06:44
@garazdawi
Copy link
Contributor

Thanks! Would you mind rebasing this for inclusion in the maint branch?

@garazdawi garazdawi removed the testing currently being tested, tag is used by OTP internal CI label Jul 10, 2020
Compilation is failing on macOS Big Sur due to in6addr_any and in6addr_loopback
being redeclared. The underlying issue is that the tests for these are failing
due to missing include statements:

conftest.c:197:1: error: implicitly declaring library function 'printf'
with type 'int (const char *, ...)' [-Werror,-Wimplicit-function-declaration]
printf("%d", in6addr_any.s6_addr[16]);
^
conftest.c:197:1: note: include the header <stdio.h> or explicitly provide
a declaration for 'printf'

ERL-1306
@AquaGeek
Copy link
Contributor Author

Rebased onto maint

@AquaGeek AquaGeek changed the base branch from master to maint July 10, 2020 16:45
@bmk bmk added the testing currently being tested, tag is used by OTP internal CI label Jul 13, 2020
@bmk bmk merged commit 4b0467c into erlang:maint Jul 27, 2020
@bmk
Copy link
Contributor

bmk commented Jul 27, 2020

Merged -> maint -> master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants