Ingela/ssl/session tickets and early data/otp 19940 #10583
+138
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngelaAndin
force-pushed
the
ingela/ssl/session-tickets-and-early-data/OTP-19940
branch
from
25fab90 to
e2752dd
Compare
Contributor
CT Test Results 2 files 66 suites 26m 0s ⏱️ Results for commit c6988db. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
If server has early_data disabled it should not include an early_data extension in its session tickets. close erlang#10567 Also fix legacy default value typo, which allows larger handshakes than previous code in legacy versions. Right should be right!
IngelaAndin
force-pushed
the
ingela/ssl/session-tickets-and-early-data/OTP-19940
branch
from
e2752dd to
c6988db
Compare
Contributor
|
Use the max size to control the extension is much nicer. |
IngelaAndin
added
the
testing
dgud
approved these changes
Jan 26, 2026
u3s
approved these changes
Jan 26, 2026
| ServerOpts = [{session_tickets, ServerTicketMode}, {early_data, disabled}, | ||
| {versions, ['tlsv1.2','tlsv1.3']}|ServerOpts0], | ||
| ServerOpts = [{session_tickets, ServerTicketMode}, | ||
| {versions, ['tlsv1.2','tlsv1.3']},{early_data, enabled} |ServerOpts0], |
Contributor
There was a problem hiding this comment.
is {early_data, disabled} + lack of extension verified somewhere, some existing testcase not changed by this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10567