-
Notifications
You must be signed in to change notification settings - Fork 3k
system: Add Secure Coding Guidelines #10431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhogberg
wants to merge
2
commits into
erlang:master
Choose a base branch
from
jhogberg:john/system/secure-coding-documentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
system: Add Secure Coding Guidelines #10431
jhogberg
wants to merge
2
commits into
erlang:master
from
jhogberg:john/system/secure-coding-documentation
+1,964
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngelaAndin
reviewed
Dec 3, 2025
IngelaAndin
reviewed
Dec 3, 2025
bjorng
reviewed
Dec 3, 2025
bjorng
reviewed
Dec 4, 2025
Contributor
bjorng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent language and sound advice. My only comments are nitpicks.
f5002c4 to
4cd1adf
Compare
Co-authored-by: "Rickard Green <rickard@erlang.org>"
dea105b to
f0819a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our benefactors want a secure coding standard/guideline for Erlang, and in contrast to EEF's Secure Coding Recommendations they want it to be more along the lines of the SEI CERT Coding Standards. We need to have numbered and concrete rules, mappings to CWEs and OWASP risks and back, and must address the top
NCWEs and OWASP risks.This is an early draft to get a discussion started on how it should look, which recommendations/rules should be included, and so on. It is quite incomplete at the moment, and any and all feedback is most welcome.