Skip to content

Conversation

@zzydxm
Copy link
Contributor

@zzydxm zzydxm commented Dec 1, 2025

Generalized data publishing logic of pg to a behavior module, so that it better supports version upgrade, and can be used for other data publishing scenarios.

I also changed the message sent between pg gen_servers to be a general update instead of tuples starts with join/leave. This makes it able to support more efficient APIs.

This replaces PR of #7609

I have a small change that makes pg:demonitor only return ok instead of ok | false, this is revertible but I believe no one is using the 'false' return

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

CT Test Results

    2 files     72 suites   1h 6m 47s ⏱️
1 687 tests 1 343 ✅ 343 💤 1 ❌
1 939 runs  1 537 ✅ 401 💤 1 ❌

For more details on these failures, see this check.

Results for commit d1f2fa0.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@max-au
Copy link
Contributor

max-au commented Dec 1, 2025

Tastes like gen_pubsub to me!
Now, while I like the general idea, when I thought of it, I'd expect it to be significantly more generic. To a degree of having local process registry - therefore not calling net_kernel:monitor_nodes at all. This is fairly common request to have "pg but local to a specific node".

@zzydxm
Copy link
Contributor Author

zzydxm commented Dec 1, 2025

Now, while I like the general idea, when I thought of it, I'd expect it to be significantly more generic. To a degree of having local process registry - therefore not calling net_kernel:monitor_nodes at all. This is fairly common request to have "pg but local to a specific node".

Oh do you mean start the gen_server without allowing it to have any cross-node communication? I can think how to add this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants