Skip to content

Conversation

MarkoMin
Copy link
Contributor

@MarkoMin MarkoMin commented Oct 5, 2025

The problem was that tokenizer returned a tuple {1, {erl_scan, {illegel, integer}}} tuple which was converted to a list but ~ts in io_lib:format required unicode and string modules.

Also, tokenizer error is now matched to embed line number correctly. I assume that tokenizer can't return eof when being run without continuation as first param so I didn't match that clause.

Error message you'll get for sys.config that contains 7k is the following:

Could not start kernel pid (application_controller) ("error in config file \"/tmp/sys.config\" (1): {erl_scan,{illegal,integer}}")

I tried testing this in the application_controller_SUITE but with no success - I tried starting slave node and match on error message, but I only got timeout. Anyone got an idea on how to test this?

Submitting fix to master branch because it occurred after in OTP28.

Ping @eproxus

Props to @richcarl for posting hints on what's going on.

Closes #10214

Copy link
Contributor

github-actions bot commented Oct 5, 2025

CT Test Results

    2 files     72 suites   1h 9m 47s ⏱️
1 685 tests 1 341 ✅ 344 💤 0 ❌
1 937 runs  1 535 ✅ 402 💤 0 ❌

Results for commit 41bc991.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@jhogberg jhogberg added the team:VM Assigned to OTP team VM label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid sys.config results in code server crash
3 participants