Fix two bottlenecks in the compiler #10252
Open
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 419 suites 1h 12m 41s ⏱️ Results for commit b25b91a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
bjorng
added
testing
lucioleKi
previously approved these changes
Oct 3, 2025
When a `case` had an extreme number of clauses, say hundred thousands or more, `erl_lint` could spending minutes instead of part of a second checking the code. The reason was a function with quadratic complexity caused by using `lists:partition/1` when `lists:splitwhile/1` would work.
When a `case` had many clauses (say hundred thousand or more) having all the same body, the beam_core_to_ssa pass could become very slow.
bjorng
force-pushed
the
bjorn/compiler/fix-bottlenecks/OTP-19797
branch
from
726d5ff to
b25b91a
Compare
lucioleKi
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a
casewith extremely many clauses (say one hundred thousand or more), compilation could become very slow (minutes instead of seconds).