ssh: ssh_sftp improve window related error handling #10035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 29 suites 18m 46s ⏱️ Results for commit 99ff120. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
u3s
force-pushed
the
kuba/ssh/window_badmatch/GH-9655/OTP-19707
branch
from
864b211 to
11ccf21
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors SFTP file operations to use the maybe ... end construct with ?= for streamlined error matching and propagation.
- Replaces
casestatements and direct=matches inopen/recv_window/send_windowwithmaybeblocks - Updates
read_file,write_file,read_repeat,read_buf,write_to_remote_tar, andwrite_bufto the new pattern - Consolidates cleanup and error return logic under unified
maybeexpressions
Comments suppressed due to low confidence (1)
lib/ssh/src/ssh_sftp.erl:1027
- Add tests for error paths in the new
maybeblocks (e.g., open/recv_window/send_window failures) to ensure correct propagation and cleanup behavior.
maybe
u3s
force-pushed
the
kuba/ssh/window_badmatch/GH-9655/OTP-19707
branch
from
11ccf21 to
99ff120
Compare
IngelaAndin
reviewed
Jul 11, 2025
IngelaAndin
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.