[erlc] miscompilation of a guard

[RobinMorisset]

Describe the bug
Running the following erlang code:

f(_, _V1) when ((ok == _V1) and (ok =/= trunc(ok))) or (ok < _V1) ->
    a;
f(_V0, _) ->
    _V0.

wrapper0() ->
    io:write(f(b, [])).

with the following two commands:

erlc -W0 ~/minimized/test329322.erl
erl -pa . -noshell -s test329322 wrapper0 -s init stop

results in the output a.
Passing +no_bool_opt to erlc makes it output b instead.

Expected behavior
trunc(ok) is always going to throw an exception, and so the whole guard should fail.
So the behavior with +no_bool_opt is I believe the right one, and should also occur without that option.

Affected versions

• master
• master + compiler: Eliminate the Kernel Erlang intermediate representation #7240

[RobinMorisset]

Two other examples that print foo by default and bar with +no_bool_opt:

f(_V0, _V1) when
    (true xor is_float(_V0)) or (is_bitstring(_V1) orelse <<(ok):(ok)/big-unit:162>>)
->
    foo;
f(_, _) ->
    bar.

wrapper0() ->
    io:write(catch f(ok, ok)).

and

f(_V0) when ((ok > _V0) and ((bnot ok) =:= ok)) or (not (ok > _V0)) ->
    foo;
f(_) ->
    bar.

wrapper0() ->
    io:write(catch f(ok)).

In both cases, I believe that bar is the right result, as the guard should fail because of an exception.