Cleanup for test, whitespace #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make lager_handler_watcher test more resilient by scanning for messages of interest rather than assuming we know exactly what messages will arrive at the test backend
|
Testing... |
|
Tests pass on R15B01, R16B02-basho10 and 18.3.3 |
| @@ -194,5 +192,17 @@ reinstall_on_runtime_failure_test_() -> | |||
| ] | |||
| }. | |||
|
|
|||
| pop_until(String, Fun) -> | |||
There was a problem hiding this comment.
Out of curiosity, what other funs might you pass in here?
There was a problem hiding this comment.
Well, I pass lists:flatten for one invocation, but wrap it with further logic (string:substr) for another, or do I misunderstand your question?
That's all I expect for now, although the pattern seems generally useful.
There was a problem hiding this comment.
Yes, that was the question. lists:flatten makes a lot of sense. The others might depend on use case. Thanks.
|
👍 124ba14 |
borshop
added a commit
that referenced
this pull request
May 19, 2016
Cleanup for test, whitespace Reviewed-by: javajolt
|
@borshop merge |
|
Nice work 🍬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messages of interest rather than assuming we know exactly what
messages will arrive at the test backend
export_allto allow R15 to run thelager_app_teststests