-
Notifications
You must be signed in to change notification settings - Fork 33
Miscellaneous quality-of-life improvements #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Less worse, at least.
.gitignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should go in your global gitignore, not in individual projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this at work and a coworker said no text temp files in gitignore and instead they should be in our global gitignore that way all projects on your machine get to ignore swap files and tags and the individual project don't get cluttered with them.
This turns out to be significantly faster for false cases, since the JS engine doesn't have to fall back to typecasting to look for some other definition of "equal". This is a microscopic speed improvement, of course, but it's the sort of thing that might matter in the guts of a VM.
|
Rebased away the |
|
👍 |
|
I've applied the build.py change and the removal of layouttestpane. As for the rest... The submodule change is a reasonable thing to ask, but I don't want to mess with that workflow right now. The submodule sync command isn't actually any easier (for me) than just copying the files over. Removing trailing whitespace is futile; it will drip back in again as I edit code. Blind changes are never a great idea. :/ |
You need a better editor then. 👿 Snarking aside, your preferred editor doesn't have a trailing white space option? |
|
I'm sure it does. Does your editor have an option to not strip it? |
|
The nice thing about submodules is that you don't even need separate checkouts; commit inside the submodule, commit outside the submodule, you're done. Between commits you don't have to copy anything at all. You only need to do the sync dance if someone else makes changes, which looks to be fairly uncommon. :) Sure. Doesn't bother me, just was an easy gotcha to fix. And yeah that's fair. :) |
These made hacking on Quixe easier for me:
src/glkotewith a submodule, which requires some light git maintenance (git submodule update --initis enough 90% of the time) but saves you from frequently copying between repos.build.pyto run with Python 3. (Arch Linux pointspythonat Python 3.)layouttestpaneand instead generate it automatically, which cuts out a big chunk of the HTML a user has to stick in a file. This is the only part to require an actual glkote bump: Get layouttest out of the core markup and generate it dynamically. glkote#4==with===, in the vain hope that it'll be slightly faster. As far as I can tell, it wasn't. Oh well.