Skip to content

Conversation

@eevee
Copy link
Contributor

@eevee eevee commented Mar 8, 2015

These made hacking on Quixe easier for me:

  • Replaced src/glkote with a submodule, which requires some light git maintenance (git submodule update --init is enough 90% of the time) but saves you from frequently copying between repos.
  • Fixed build.py to run with Python 3. (Arch Linux points python at Python 3.)
  • Stripped all trailing whitespace from the Quixe source. (I have some vim plugin that does this on save, and it kept adding tons of patch noise.)
  • Cut out layouttestpane and instead generate it automatically, which cuts out a big chunk of the HTML a user has to stick in a file. This is the only part to require an actual glkote bump: Get layouttest out of the core markup and generate it dynamically. glkote#4
  • Blindly replace == with ===, in the vain hope that it'll be slightly faster. As far as I can tell, it wasn't. Oh well.

.gitignore Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should go in your global gitignore, not in individual projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this at work and a coworker said no text temp files in gitignore and instead they should be in our global gitignore that way all projects on your machine get to ignore swap files and tags and the individual project don't get cluttered with them.

http://stackoverflow.com/a/7335487/227176

eevee added 6 commits March 9, 2015 21:08
This turns out to be significantly faster for false cases, since the JS
engine doesn't have to fall back to typecasting to look for some other
definition of "equal".  This is a microscopic speed improvement, of
course, but it's the sort of thing that might matter in the guts of a
VM.
@eevee
Copy link
Contributor Author

eevee commented Mar 10, 2015

Rebased away the .gitignore.

@sukima
Copy link

sukima commented Mar 10, 2015

👍

@erkyrath
Copy link
Owner

I've applied the build.py change and the removal of layouttestpane. As for the rest...

The submodule change is a reasonable thing to ask, but I don't want to mess with that workflow right now. The submodule sync command isn't actually any easier (for me) than just copying the files over.

Removing trailing whitespace is futile; it will drip back in again as I edit code.

Blind changes are never a great idea. :/

@sukima
Copy link

sukima commented Mar 19, 2015

Removing trailing whitespace is futile; it will drip back in again as I edit code.

You need a better editor then. 👿 Snarking aside, your preferred editor doesn't have a trailing white space option?

@erkyrath
Copy link
Owner

I'm sure it does. Does your editor have an option to not strip it?

@eevee
Copy link
Contributor Author

eevee commented Mar 23, 2015

The nice thing about submodules is that you don't even need separate checkouts; commit inside the submodule, commit outside the submodule, you're done. Between commits you don't have to copy anything at all. You only need to do the sync dance if someone else makes changes, which looks to be fairly uncommon. :)

Sure. Doesn't bother me, just was an easy gotcha to fix.

And yeah that's fair. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants