Check that there are enough snapshots before diff #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikw
requested changes
Aug 8, 2025
bin/restic_backup.sh
Outdated
| snapshotId=$(echo "$latest_snapshots" | cut -d ' ' -f2) | ||
| statsMsg="Added: ${added}. Removed: ${removed}. Snap size: ${snapshot_size}" | ||
| fi | ||
|
|
||
| latest_snapshot_diff=$(echo "$latest_snapshots" | xargs restic diff) |
There was a problem hiding this comment.
It looks like you forgot to remove the snapshot calculation lines, that are now copied to the else branch.
Probably the echo "$statsMsg" and 2 lines below should also be in the new else?
There was a problem hiding this comment.
Hey, sorry about that! I have a slightly modified copy of this in my Ansible repository and I forgot to remove the snapshot calculation lines when moving it over to this repository.
Good point on the following two lines - when I tested it as-is, no errors were returned, but it doesn't make sense to call these functions without the data.
Delete duplicate code and pull usage of the calculated stats into the conditional block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first run after init'ing tends to cause a systemd failure due to not having enough snapshots for statistics.