Skip to content

Try to work with %%time and %%timeit IPython magic. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Conversation

eriknw
Copy link
Owner

@eriknw eriknw commented Aug 19, 2021

Fixes #10. This is a pretty narrow fix that only applies to time and timeit.

@jrbourbeau care to give this a try, or should I just cut a release and hope for the best?

Testing notebooks is on my TODO list (and I want it to count towards line coverage too). I'll be sure to add %%time and %%timeit. I figured the line magic %time wasn't worth supporting.

Fixes #10.  This is a pretty narrow fix that only applies to time and timeit.
Copy link
Contributor

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eriknw! I can definitely take this for a spin

eriknw and others added 2 commits August 19, 2021 18:21
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
@jrbourbeau
Copy link
Contributor

I can confirm this fixes the issue I was seeing earlier today 👍

@eriknw eriknw merged commit 9a144a6 into main Aug 20, 2021
@eriknw eriknw deleted the support_time_magic branch August 20, 2021 02:33
@jrbourbeau
Copy link
Contributor

Thanks @eriknw!

@eriknw
Copy link
Owner Author

eriknw commented Aug 20, 2021

My pleasure! Lmao, afar is surprisingly fun to work on: "How I learned to stop worrying and love the [hacks]".

Thanks again for giving this a try and caring enough to raise issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using %%time Jupyter magic
2 participants