Repository navigation
Paperdoll: the shield slot takes a one-handed melee weapon (fix #225) - #231
Merged
Merged
Conversation
Dragging a one-handed melee weapon onto the paperdoll's shield slot was refused: the slot accepted an item only when its own valid locations named the shield slot, and a weapon's never do. The original client treats the shield slot as also accepting anything that fits the melee weapon slot and wields it in the off hand, sending the shield-slot location; whatever is already in the shield slot is moved to the backpack first. Whether the character can dual wield is left to the server, as before. The drop now goes through the existing off-hand wield transaction, so the request and the blocker handling match the secondary-wield path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A shield dropped on the paperdoll's shield slot while a weapon sat there as the off hand was sent to be wielded straight away, and the server refused it because the slot was taken. The original client treats the shield slot the same whatever is dropped on it: an empty slot is wielded into at once, and whatever holds it is moved to the backpack first, then the wield follows. The explicit shield-slot request now does the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225.
The paperdoll's shield slot now accepts a one-handed melee weapon and wields it in the off hand, as the original client does: the shield slot takes anything that can go in the melee weapon slot (bows, casters and two-handers are refused). The wield request sends the shield-slot location; a shield already there goes to the pack first. The client does not check the Dual Wield skill; the server decides (ACE accepts a melee weapon in the shield slot).
ItemEquipRules: shield-slot widening rule.PaperdollController: drag-over uses it; a drop routes to the existing off-hand wield path.🤖 Generated with Claude Code