Repository navigation
Salvage: a dropped pack adds its own items, not its side packs' (fix #221) - #230
Merged
Merged
Conversation
…221) Dropping the main pack onto the salvage window staged every salvageable item the character carried, side packs included. The salvage window walks a container's item list only; packs and foci sit in a separate container list and are never visited, so the main pack contributes just the items lying in it, and a side pack's items arrive only when that pack is dropped. ClientObjectTable.GetContainedItems returns that item list (the contents minus the container-list members), and the salvage controller uses it both to decide whether a drop is a container drop and to walk the contents. A main pack holding nothing but side packs is therefore judged as an item, and rejected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #221.
Dropping the main pack onto the salvage window staged every salvageable item the character carried, side packs included. The original client's salvage window walks a container's item list only; packs and foci sit in a separate list and are never visited. So the main pack now adds just the items lying in it, and a side pack's items arrive only when that pack is dropped. A main pack holding nothing but side packs is judged as an item (and rejected).
ClientObjectTable.GetContainedItems: contents minus packs and foci.SalvageUiController.CanAdd/AddRecursiveuse it.🤖 Generated with Claude Code