Skip to content

Fix the late-row fixed-clock test that fails every run since 2026-10-10 (#5661) #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Oct 11, 2026
Merged

Fix the late-row fixed-clock test that fails every run since 2026-10-10 (#5661) #5662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Darling/Darling.Tests/PlanRegressionBuiltDaysFallbackLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,17 +138,20 @@ public async Task ADailyTotalsChange_BetweenTheBuiltDaysReadAndTheDailyRead_IsNo
public Task ADayMarkedByALateRow_DropsOutOfTheBuiltDays_AndIsReadLive() => RunLateRowAsync(utcNow: null);

/// <summary>
/// The same assertions at a fixed clock, so the late-row test means the same all day. Before 04:00 UTC the window's start
/// (four hours back) is on the previous calendar day, so the window's first day is fifteen days before today; from 04:00
/// UTC it is fourteen. The cases straddle that edge (the last minute before 04:00, and 04:00 itself) and a mid-day one.
/// The same assertions at a fixed time of day, so the late-row test means the same all day. Before 04:00 UTC the window's
/// start (four hours back) is on the previous calendar day, so the window's first day is fifteen days before today; from
/// 04:00 UTC it is fourteen. The cases straddle that edge (the last minute before 04:00, and 04:00 itself) and a mid-day
/// one. The date is today's (read once), not a pinned calendar day: the late-row trigger windows on the database's own
/// <c>now()</c> (it marks a row only 1 to 17 days old), so a pinned date ages out of that reach and the trigger skips the
/// row (#5661). The hour and minute are what the case pins.
/// </summary>
[Theory]
[InlineData(0, 30)]
[InlineData(3, 59)]
[InlineData(4, 0)]
[InlineData(12, 0)]
public Task ADayMarkedByALateRow_DropsOutOfTheBuiltDays_AndIsReadLive_AtAFixedClock(int hour, int minute) =>
RunLateRowAsync(new DateTime(2026, 10, 7, hour, minute, 0, DateTimeKind.Utc));
RunLateRowAsync(DateTime.SpecifyKind(DateTime.UtcNow.Date, DateTimeKind.Utc).AddHours(hour).AddMinutes(minute));

private static async Task RunLateRowAsync(DateTime? utcNow)
{
Expand Down
Loading