Repository navigation
Release checklist: Azure SQL Database skips and the forced firewall outage, as tested for 3.10.0 - #5545
Merged
Conversation
…utage, as tested for 3.10.0 Step 5 asked for SKIPPED rows from collectors that do not apply to Azure SQL Database. Darling marks the SQL Agent collectors not applicable when the server is added and never runs them, so they leave no row. Two test runs flagged that against the old wording. The step also had no way to force a firewall outage: deleting the rule leaves open connections alone. It now says how to cut Darling's sessions and what to check.
12 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5 of the release checklist asked for SKIPPED rows from collectors that do not apply to Azure SQL Database. Darling marks the SQL Agent collectors (running_jobs, job_history, agent_status) not applicable when the server is added and never runs them, so they leave no collection_log row and no health entry. Both 3.10.0 test runs flagged that against the old wording. The step now describes what really happens, and the success line says no inapplicable collector may be recorded as a failure.
The firewall churn step already warned that deleting the rule does not break open connections. The 3.10.0 runs showed that twice. The step now says how to force a real outage: open admin sessions first, delete the rule, wait 6 minutes, then KILL Darling's sessions in each user database (KILL is denied in master). Collectors that open new connections then hit 40615. The log message must name the firewall, and the collectors must store rows again after the rule comes back, without a service restart.
Doc-only change to .claude/skills/release-checklist/SKILL.md. No build or tests involved.