Repository navigation
The first start after the schema 165 upgrade takes the legacy password pins before it reads the server list, so saved passwords keep working - #5456
Merged
Conversation
…d pins before it reads the server list, so saved passwords keep working (#5455)
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5455.
Why
On the first start after the schema 165 upgrade, the service read the server list before it took the pins for saved old-format passwords. The view reads the pins, found none, and built every server with no pin. The pin snapshot ran about 40 lines later but does not bump the config version, so no reload followed. Every server whose saved password darling.json does not declare stayed down for the whole run. On two production stores, 24 of 42 servers and 49 of 50 targets did not collect until a second restart, which found the pins.
What changes
DarlingWorker.ExecuteAsyncnow starts the password key runtime (key load and legacy pin snapshot) afterSeedIfEmptyAsyncand before the firstLoadViewAsync. It is still after migrations and role provisioning, and after the seed so seeded rows are pinned. The comment at the call site says why.StartForServiceAsyncreads onlyconfig.Postgres(through the key directory choice), andApplyToConfigwrites none of thePostgressettings, so the start does not depend on anything the view changes.Test plan
SeedIfEmptyAsync(and before the firstLoadViewAsync(. RED on dev's order (failed there), green here.CHANGELOG entry
SECTION: Fixed