Repository navigation
LITE: the Overview blocking chart says where its data starts (part of #4966) - #5111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lite's Overview blocking and deadlock chart draws event counts, so an empty stretch before a series starts read as "nothing happened". The chart now carries a "Showing since " note above it when its data starts after the window does. This is the Lite twin of the desktop viewer's #5024 and the last surface of #4966's Lite list.
What users see change
What changes
LiteBlockingLaneDataStart(new, static, no WPF): each series' start is the earlier of its coverage floor and its earliest bar with a count above zero; a probe that throws costs only its series' start and is logged.CorrelatedTimelineLanesControl: after every chart, the ghost lines and the axis sync are drawn, the note step probesBlockedProcessReportsandDeadlocksover the same UTC window the two reads took (LocalDataService.GetTimeRange). The probes are outside the reads'WhenAll; a probe failure never touches the bars.DynamicResourceforeground.Test plan
Lite.Tests, on the Windows VM:
257213d65: the three new classes, 16 tests (logic 7, live store 5, wiring pin 4), 0 failed.OverviewBlockingLaneDataStartTests(logic): the later of the two starts; one series only; a failed probe on one side; zero buckets ignored; neither gives no note; plus the probing half of the note step, driven without WPF.OverviewBlockingLaneDataStartLiveTests(store, fixed anchors): the notice, the quiet start, one series, a failed probe and a short window, through the real note step.OverviewBlockingLaneDataStartPinTests(wiring): the refresh calls the note step after the blocking chart is drawn; the step probes both relations over the reads' window and passes the bar times; the XAML carries the banner.dev(which now carries LITE: the Blocking Trends, Blocking Stats and Lock Wait Trend charts say where their data starts (part of #4966) #5096) before opening.Limits
CHANGELOG
SECTION: Fixed
ENTRY: - The Overview blocking and deadlock chart now says where its data starts ([#5111]) - a "Showing since" note appears above the chart when the data begins after the window does, so an empty stretch no longer reads as "nothing happened".
REF: [#5111]: #5111