Repository navigation
The member scan's known-truncated roster names the buffer drill-down's nullable rounder (#3691 lane 29 residue; dev red since #3795) - #3804
Merged
Conversation
erikdarlingdata
enabled auto-merge (squash)
September 20, 2026 16:16
54 of 55 tasks
erikdarlingdata
disabled auto-merge
September 20, 2026 16:19
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dev has been red on
TsqlConventionGuardTests.TheMemberScan_ReadsEveryDeclarationWholesince #3795 (lane 29 of #3691): the buffer-composition drill-down added a nullable four-place rounder,PgTargetDrillDownCollector.Buffer.cs Round, whose declaration range the member scan reads short — the same expression-shaped helper as theFigure/Count/Tallyformatter lines already on the roster. What its range strands isMath.Round(value.Value, 4)and nothing else: no T-SQL, no tempdb label, no SQL literal any census reads, so the scan stopping short of it loses no counted site. The test itself says "edit KnownTruncatedRanges to match and say which in the PR body": the direction is ARRIVED, one line, with the reason beside it.One file, test roster only; no product change. #3799 (the drill-down's other census fix) did not cover this one.
Which component(s) does this affect?
How was this tested?
Darling.Testsbuilds (-p:EnableWindowsTargeting=true, 0 warnings / 0 errors); the class executes in CI'sbuildandDarling PostgreSQL testsjobs, which listed exactly this one member. CRLF preserved (verified byte-wise).Checklist